User talk:Pmllc

From Wiki
Jump to: navigation, search

Hi pmllc

concerning your changes to Hugin SDK (MSVC_2013)#panotools

You are right, libpano can also built without the BUILD_DLL entry. But in this case a static libpano is build, which is linked against the static VC runtime. But in this instructions all other libs are built as shared libs (dll) and are linked against the dynamic VC runtime and we want to keep a consistent linkage. Also when libpano13.dll is missing, Hugins install target will barf and will not finish.

If you think the switch is not necessary, so please explain it more verbose.

Hi Thomas, no problem.

The only thing is that BUILD_DDL was already defined with the good value. With this in mind it was not mandatory to force it (As I wasn't aware of the reason of this, this was the reason I just striked it).

Pmllc (talk) 12:57, 28 June 2015 (UTC)

That's strange. The default value in CMakeLists.txt is off

     OPTION(BUILD_DLL "Build dynamic libpano 13" OFF)

The CMake code to handle is flag is currently a little bit fragile. When you change this value later, it does not correctly propagate to all places for MSVC (it can be handled manually, but setting it before is currently more robust). Thomas (talk) 15:41, 29 June 2015 (UTC)